Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Action CLI #214

Merged
merged 20 commits into from
Apr 14, 2019
Merged

Add Action CLI #214

merged 20 commits into from
Apr 14, 2019

Commits on Apr 3, 2019

  1. Add ros2action package 

    Contains ros2cli command 'action' with verbs: list and show.
The list verb lists action names for any running action servers and action clients.
The show verb prints the definition for a given action type.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    d0cc82a View commit details
    Browse the repository at this point in the history

  2. Add 'info' verb to action command 

    Prints a list of node names that have an action client or server for a given action name.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    7d022a4 View commit details
    Browse the repository at this point in the history

  3. Use None as argument to test node 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    d81668c View commit details
    Browse the repository at this point in the history

  4. Add TODOs to move action query functions to rclpy (and rcl_action) 

    The tool shouldn't need to know details about the implementation of actions.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    d0c4d23 View commit details
    Browse the repository at this point in the history

  5. Add dependency to rclpy 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    e6eca00 View commit details
    Browse the repository at this point in the history

  6. Add 'send_goal' verb to action command 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    f5077f8 View commit details
    Browse the repository at this point in the history

  7. Migrate message utility functions to rosidl_runtime_py 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    32ecb32 View commit details
    Browse the repository at this point in the history

  8. Make use of rclpy functions 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    4588586 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2019

  1. Fix lint 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    5e324d1 View commit details
    Browse the repository at this point in the history

  2. Fix tests 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    eb7ba1f View commit details
    Browse the repository at this point in the history

  3. Fix test 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    62b2d40 View commit details
    Browse the repository at this point in the history

  4. Add autocompletion to verbs 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    bdab18a View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2019

  1. Update year 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    4f39c2b View commit details
    Browse the repository at this point in the history

  2. Expand and validate action name 

    This also has the side-effect of making the forward slash optional for the action name.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    0d13d00 View commit details
    Browse the repository at this point in the history

  3. Print goal ID when sendind a goal 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    8ef62e0 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. Cancel goal on SIGINT 

    Wrapped send goal logic in try-finally clause.
This ensures that any active goal will be canceled before the CLI command terminates and also ensure that the ROS node is shutdown.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    89902d5 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. Fix typos 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    5bc307f View commit details
    Browse the repository at this point in the history

  2. Change maintainer 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 12, 2019
    2 Configuration menu
    Copy the full SHA
    71de0e5 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2019

  1. Move try-except to verb 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 13, 2019
    1 Configuration menu
    Copy the full SHA
    bbd8893 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2019

  1. Catch expected exceptions only 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    6a62cb8 View commit details
    Browse the repository at this point in the history