Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unresolved external symbol __progname #94

Closed
felixf4xu opened this issue May 25, 2023 · 2 comments · Fixed by #97
Closed

unresolved external symbol __progname #94

felixf4xu opened this issue May 25, 2023 · 2 comments · Fixed by #97
Assignees
@mossmaurice
Labels
bug Something isn't working

Comments

@felixf4xu
Copy link

Hi,

I'm trying to build (branch humble) in win11 and VS2022 and I had a link error:

rmw_init.obj : error LNK2001: unresolved external symbol __progname [C:\ros\humble\build\rmw_iceoryx_cpp\rmw_iceoryx_cpp.vcxproj]

the code is at:

rmw_iceoryx/rmw_iceoryx_cpp/src/rmw_init.cpp

Line 98 in 4134ce2

extern char * __progname;

I searched but the extern name of __progname is never found. Then in the whole source code of ROS2, I found

https://github.com/ros2/rcutils/blob/025f78fa7c03666b5fa1057af00a32ed8bbd64a0/src/process.c#LL71C1-L74C6

#elif defined __QNXNTO__ || defined __OHOS__
  extern char * __progname;
  const char * appname = __progname;
#else

but I'm not sure if it's related.
@mossmaurice mossmaurice added the bug Something isn't working label Sep 16, 2023
@mossmaurice mossmaurice self-assigned this Sep 16, 2023
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Sep 16, 2023
@mossmaurice
Use 'rcutils_get_executable_name' to get the name of the process (ros…
91d6863 
…2#94)
@mossmaurice mossmaurice mentioned this issue Sep 16, 2023
Merged
@mossmaurice
Copy link
Collaborator

@felixf4xu Thanks for reporting this issue and apologies for the late reply!

You are right, rcutils offers a platform-independent rcutils_get_executable_name function to get the process name. I opened #97.

However, please be aware Windows is not (yet) officially supported. Hence, you might bump into other unknown issues. Feel free to report them or even to fix them ☺️

mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Sep 16, 2023
@mossmaurice
Use 'rcutils_get_executable_name' to get the name of the process (ros…
f960231 
…2#94)

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Sep 16, 2023
@mossmaurice
Use 'rcutils_get_executable_name' to get the name of the process (ros…
f80bf33 
…2#94)

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Sep 18, 2023
@mossmaurice
Use 'rcutils_get_executable_name' to get the name of the process (ros…
e90e268 
…2#94)

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice added a commit that referenced this issue Sep 18, 2023
@mossmaurice
Use 'rcutils_get_executable_name' to get the name of the process (#94) (
4936431 
#97)

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@felixf4xu
Copy link
Author

@mossmaurice thanks for the fix, it works in my build.

@felixf4xu felixf4xu mentioned this issue Sep 20, 2023
Closed
mossmaurice added a commit that referenced this issue Sep 20, 2023
@mossmaurice
Forward port changes from humble to master branch (#98)
91080ff 
* Use new Blueberry v2.0.3 feature request-response and its discovery (#84)

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>

* Remove cppcheck from linter job and use Ubuntu 22.04

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>

* Include 'iceoryx_hoofs' legacy header and use 'iox::into' for string
conversion

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>

* Fix dependency of name conversion lib (#81)

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>

* Call correct destructor (#81)

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>

* Use 'rcutils_get_executable_name' to get the name of the process (#94)

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>

* Set C++ standard in accordance with iceoryx (#93)

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>

* Address review findings (#84)

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>

---------

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mossmaurice mossmaurice

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use rcutils_get_executable_name to get the name of the process ApexAI/rmw_iceoryx
2 participants
@mossmaurice @felixf4xu