-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update service/client request/response API error returns #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
hidmic
reviewed
Sep 24, 2020
hidmic
approved these changes
Sep 24, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
hidmic
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending green CI including tests.
Lobotuerk
changed the title
Updated error returns on rmw_send_request
Update service request/response API error returns
Sep 28, 2020
Lobotuerk
changed the title
Update service request/response API error returns
Update service/client request/response API error returns
Sep 28, 2020
Blast545
approved these changes
Sep 28, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@ros-pull-request-builder retest this please. |
Github Actions keep complaining about internal errors in MacOS jobs. Consider our CI is green and all other jobs are passing, I'll move forward with this PR. |
delete-merged-branch
bot
deleted the
lobotuerk/update-send-request-returns
branch
September 29, 2020 00:50
ahcorde
pushed a commit
that referenced
this pull request
Oct 9, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 15, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lobotuerk jtlorente@ekumenlabs.com