Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service/client request/response API error returns #249

Merged
merged 7 commits into from
Sep 29, 2020

Conversation

Lobotuerk
Copy link
Contributor

Signed-off-by: lobotuerk jtlorente@ekumenlabs.com

Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk
Copy link
Contributor Author

CI job up to rcl and test_rmw_implementation:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Lobotuerk Lobotuerk marked this pull request as draft September 25, 2020 16:45
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk Lobotuerk marked this pull request as ready for review September 28, 2020 19:45
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI including tests.

@Lobotuerk Lobotuerk changed the title Updated error returns on rmw_send_request Update service request/response API error returns Sep 28, 2020
@Lobotuerk Lobotuerk changed the title Update service request/response API error returns Update service/client request/response API error returns Sep 28, 2020
@Lobotuerk
Copy link
Contributor Author

CI up to rcl and test_rmw_implementation:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

rmw_cyclonedds_cpp/src/rmw_node.cpp Outdated Show resolved Hide resolved
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk
Copy link
Contributor Author

CI after reviews, up to rcl and test_rmw_implementation:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Lobotuerk
Copy link
Contributor Author

@ros-pull-request-builder retest this please.

@hidmic
Copy link
Contributor

hidmic commented Sep 29, 2020

Github Actions keep complaining about internal errors in MacOS jobs. Consider our CI is green and all other jobs are passing, I'll move forward with this PR.

@hidmic hidmic merged commit 2961f75 into master Sep 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the lobotuerk/update-send-request-returns branch September 29, 2020 00:50
ahcorde pushed a commit that referenced this pull request Oct 9, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
ahcorde pushed a commit that referenced this pull request Oct 15, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants