-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update graph API return codes. #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for going over all the argument checking and return values with such care!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jacobperron I believe the problem with #241 was that CI was not properly run against actual tests (see here). Every modification here is checked against a corresponding test. |
This patch affects: - rmw_get_node_names() - rmw_get_node_names_with_enclaves() - rmw_get_topic_names_and_types() - rmw_get_service_names_and_types() - rmw_get_publishers_info_by_topic() - rmw_get_subscriptions_info_by_topic() - rmw_get_subscriber_names_and_types_by_node() - rmw_get_publisher_names_and_types_by_node() - rmw_get_service_names_and_types_by_node() - rmw_get_client_names_and_types_by_node() - rmw_count_publishers() - rmw_count_subscribers() Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
a0a74a5
to
0757fd2
Compare
Argh, I had to rebase after #245. CI up to |
Alright, going in! Thanks for all the good reviews! |
This patch affects: - rmw_get_node_names() - rmw_get_node_names_with_enclaves() - rmw_get_topic_names_and_types() - rmw_get_service_names_and_types() - rmw_get_publishers_info_by_topic() - rmw_get_subscriptions_info_by_topic() - rmw_get_subscriber_names_and_types_by_node() - rmw_get_publisher_names_and_types_by_node() - rmw_get_service_names_and_types_by_node() - rmw_get_client_names_and_types_by_node() - rmw_count_publishers() - rmw_count_subscribers() Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This patch affects: - rmw_get_node_names() - rmw_get_node_names_with_enclaves() - rmw_get_topic_names_and_types() - rmw_get_service_names_and_types() - rmw_get_publishers_info_by_topic() - rmw_get_subscriptions_info_by_topic() - rmw_get_subscriber_names_and_types_by_node() - rmw_get_publisher_names_and_types_by_node() - rmw_get_service_names_and_types_by_node() - rmw_get_client_names_and_types_by_node() - rmw_count_publishers() - rmw_count_subscribers() Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Connected to ros2/rmw#272. This patch affects:
rmw_get_node_names()
rmw_get_node_names_with_enclaves()
rmw_get_topic_names_and_types()
rmw_get_service_names_and_types()
rmw_get_publishers_info_by_topic()
rmw_get_subscriptions_info_by_topic()
rmw_get_subscriber_names_and_types_by_node()
rmw_get_publisher_names_and_types_by_node()
rmw_get_service_names_and_types_by_node()
rmw_get_client_names_and_types_by_node()
rmw_count_publishers()
rmw_count_subscribers()