Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated error returns on rmw_take_serialized and with_message_info #242

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Updated error returns on rmw_take_serialized and with_message_info #242

merged 3 commits into from
Sep 18, 2020

Conversation

Lobotuerk
Copy link
Contributor

Signed-off-by: lobotuerk jtlorente@ekumenlabs.com

@Lobotuerk
added take_serialization_errors
fd3ef8f 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk Lobotuerk changed the title Add tests take serialized bad arguments Updated error returns on rmw_take_serialized Sep 17, 2020
@Lobotuerk
updated erros take_serialized_with_message_info
b69eeaa 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk Lobotuerk changed the title Updated error returns on rmw_take_serialized Updated error returns on rmw_take_serialized and with_message_info Sep 18, 2020
hidmic
hidmic approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

rmw_cyclonedds_cpp/src/rmw_node.cpp Show resolved Hide resolved
@Lobotuerk
reviews
a3d1e60 
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Lobotuerk Lobotuerk merged commit 0c51ac8 into master Sep 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the lobotuerk/take_serialized_errors branch September 18, 2020 21:42
ahcorde pushed a commit that referenced this pull request Oct 9, 2020
@Lobotuerk @ahcorde
Updated error returns on rmw_take_serialized and with_message_info (#242
fcf4ea1 
)

Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
ahcorde pushed a commit that referenced this pull request Oct 15, 2020
@Lobotuerk @ahcorde
Updated error returns on rmw_take_serialized and with_message_info (#242
4682af4 
)

Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blast545 Blast545 Blast545 approved these changes

@hidmic hidmic hidmic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lobotuerk @Blast545 @hidmic