This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Update graph API return codes. #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch affects: - rmw_get_node_names() - rmw_get_node_names_with_enclaves() - rmw_get_topic_names_and_types() - rmw_get_service_names_and_types() - rmw_get_publishers_info_by_topic() - rmw_get_subscriptions_info_by_topic() - rmw_get_subscriber_names_and_types_by_node() - rmw_get_publisher_names_and_types_by_node() - rmw_get_service_names_and_types_by_node() - rmw_get_client_names_and_types_by_node() - rmw_count_publishers() - rmw_count_subscribers() Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
reviewed
Sep 21, 2020
Comment on lines
+45
to
47
| if (RMW_RET_OK != rmw_check_zero_rmw_string_array(node_names)) { | ||
| return RMW_RET_INVALID_ARGUMENT; | ||
| } |
There was a problem hiding this comment.
this seems inconsistent with:
ret = rmw_names_and_types_check_zero(topic_names_and_types);
if (RMW_RET_OK != ret) {
return ret;
}
There was a problem hiding this comment.
My guess is that rmw_check_zero_rmw_string_array(node_names) does not return RMW_RET_INVALID_ARGUMENT
There was a problem hiding this comment.
ok, it's a bit weird the semantic different between the two, but it doesn't matter much,
There was a problem hiding this comment.
Indeed. rmw_check_zero_rmw_string_array returns RMW_RET_INVALID_ARGUMENT if the argument is NULL, and RMW_RET_ERROR if it's not zero initialized. We can change rmw_names_and_types_check_zero call sites to the do the same for consistency's sake though.
ivanpauno
approved these changes
Sep 21, 2020
|
CI up to
|
|
CI up to
|
|
Alright, going in! Thanks for all the good reviews! |
ahcorde
pushed a commit
that referenced
this pull request
Oct 9, 2020
This patch affects: - rmw_get_node_names() - rmw_get_node_names_with_enclaves() - rmw_get_topic_names_and_types() - rmw_get_service_names_and_types() - rmw_get_publishers_info_by_topic() - rmw_get_subscriptions_info_by_topic() - rmw_get_subscriber_names_and_types_by_node() - rmw_get_publisher_names_and_types_by_node() - rmw_get_service_names_and_types_by_node() - rmw_get_client_names_and_types_by_node() - rmw_count_publishers() - rmw_count_subscribers() Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 15, 2020
This patch affects: - rmw_get_node_names() - rmw_get_node_names_with_enclaves() - rmw_get_topic_names_and_types() - rmw_get_service_names_and_types() - rmw_get_publishers_info_by_topic() - rmw_get_subscriptions_info_by_topic() - rmw_get_subscriber_names_and_types_by_node() - rmw_get_publisher_names_and_types_by_node() - rmw_get_service_names_and_types_by_node() - rmw_get_client_names_and_types_by_node() - rmw_count_publishers() - rmw_count_subscribers() Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to ros2/rmw#272. This patch affects:
rmw_get_node_names()rmw_get_node_names_with_enclaves()rmw_get_topic_names_and_types()rmw_get_service_names_and_types()rmw_get_publishers_info_by_topic()rmw_get_subscriptions_info_by_topic()rmw_get_subscriber_names_and_types_by_node()rmw_get_publisher_names_and_types_by_node()rmw_get_service_names_and_types_by_node()rmw_get_client_names_and_types_by_node()rmw_count_publishers()rmw_count_subscribers()