Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Ensure compliant node construction/destruction API. #439

Merged
merged 6 commits into from
Jul 15, 2020
Merged

Ensure compliant node construction/destruction API. #439

merged 6 commits into from
Jul 15, 2020

Commits on Jul 13, 2020

  1. Ensure compliant node construction/destruction API. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    04f4642 View commit details
    Browse the repository at this point in the history

  2. Use known validation result values. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    9851bf1 View commit details
    Browse the repository at this point in the history

  3. Complete node destruction after runtime failure. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    3e3a1c5 View commit details
    Browse the repository at this point in the history

  4. Drop unnecessary assertions. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    555e7ab View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. Fix clang warnings. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    5666b86 View commit details
    Browse the repository at this point in the history

  2. Address last peer review comment. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    41b3079 View commit details
    Browse the repository at this point in the history