This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Ensure compliant init options API implementations. #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
CI up to
|
ivanpauno
reviewed
Jun 23, 2020
rmw_connext_cpp/src/rmw_init.cpp
Outdated
|
|
||
| rmw_ret_t ret = rmw_security_options_fini(&init_options->security_options, allocator); | ||
| if (RMW_RET_OK == ret) { | ||
| allocator->deallocate(init_options->enclave, allocator->state); |
There was a problem hiding this comment.
ivanpauno
approved these changes
Jun 23, 2020
ivanpauno
reviewed
Jun 23, 2020
| RMW_CHECK_TYPE_IDENTIFIERS_MATCH( | ||
| init_options, | ||
| init_options->implementation_identifier, | ||
| rti_connext_identifier, | ||
| return RMW_RET_INCORRECT_RMW_IMPLEMENTATION); | ||
| allocator.deallocate(init_options->enclave, allocator.state); | ||
| rmw_security_options_fini(&init_options->security_options, &allocator); |
There was a problem hiding this comment.
unrelated, but we need to add RMW_WARN_UNUSED to this function declaration
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
One last sanity CI run after API contract updates:
|
ahcorde
pushed a commit
that referenced
this pull request
Oct 8, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 15, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complying with ros2/rmw#244.