This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Avoid leaking init options in context. #429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
approved these changes
Jun 22, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
reviewed
Jun 23, 2020
| rmw_ret_t ret = rmw_init_options_copy(options, &context->options); | ||
| if (RMW_RET_OK != ret) { | ||
| return ret; | ||
| goto fail; |
There was a problem hiding this comment.
I think that the point that was raised in rmw_cyclonedds PR is valid here too.
If rmw_init_options_copy failed, there shouldn't be a need to call rmw_init_options_fini.
If that's needed, it's because rmw_init_options_copy is not handling errors properly.
There was a problem hiding this comment.
|
This has been superseded by #432. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin off form #428.