Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node creation/destruction API documentation. #249

Merged
merged 6 commits into from
Jul 15, 2020
Merged

Update node creation/destruction API documentation. #249

merged 6 commits into from
Jul 15, 2020

Commits on Jul 14, 2020

  1. Update node creation/destruction API documentation. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    fd3fd5a View commit details
    Browse the repository at this point in the history

  2. Address peer review comments. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    bef9236 View commit details
    Browse the repository at this point in the history

  3. Address more peer review comments. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    6317019 View commit details
    Browse the repository at this point in the history

  4. Cannot use namespace as argument name. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    cd485f4 View commit details
    Browse the repository at this point in the history

  5. Clarify rmw_destroy_node() side effects. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    d9930ed View commit details
    Browse the repository at this point in the history

  6. Address last peer review comment. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    79648b3 View commit details
    Browse the repository at this point in the history