Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename rmw_topic_endpoint_info_array count to size, and initialize it #196

Merged
merged 4 commits into from
Feb 20, 2020
Merged

Rename rmw_topic_endpoint_info_array count to size, and initialize it #196

merged 4 commits into from
Feb 20, 2020

Conversation

ivanpauno
Copy link
Member

When rmw_topic_endpoint_info_array_init_with_size was called, count was not initialized.
I renamed count to size, and initialize it with the reserved size.
I think that's more consistent with what we were doing in other arrays.

@ivanpauno
Change rmw_topic_endpoint_info_array.count to .size
8b19c88 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Feb 12, 2020
@ivanpauno ivanpauno self-assigned this Feb 12, 2020
@ivanpauno ivanpauno mentioned this pull request Feb 12, 2020
Merged
@ivanpauno
Copy link
Member Author

I will have to send a similar PR that ros2/rmw_fastrtps#348 to rmw_cyclonedds_cpp.

@ivanpauno
Address peer review comments
ef8312d 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
hidmic
hidmic approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

@ivanpauno ivanpauno mentioned this pull request Feb 13, 2020
Merged
@ivanpauno
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status

@ivanpauno
Copy link
Member Author

ivanpauno commented Feb 17, 2020 •
edited
Loading

New CI, including ros2/rcl#576:

  • Linux Build Status

This was referenced Feb 17, 2020
Merged
Merged
Merged
@ivanpauno
Copy link
Member Author

Again, including ros2/rclpy#510 and ros2/rclcpp#996:

  • Linux Build Status

@ivanpauno
Initialize size.
ddcd2fc 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Fix test failures
d70bdd1 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Member Author

  • Linux Build Status

@ivanpauno
Copy link
Member Author

ivanpauno commented Feb 18, 2020 •
edited
Loading

  • AArch64 Build Status
  • OsX Build Status (unrelated failures)
  • Windows Build Status (unrelated failures)

hidmic
hidmic approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivanpauno ivanpauno merged commit 28f9185 into master Feb 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/endpoint-topic-info-count-to-size branch February 20, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@ivanpauno ivanpauno

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanpauno @hidmic