Drop vsnprintf mocks entirely. #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary API is not portable across platforms and compilation config. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
approved these changes
Aug 11, 2020
|
Alright, going in. |
ahcorde
pushed a commit
that referenced
this pull request
Oct 2, 2020
Binary API is not portable across platforms and compilation config. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 6, 2020
Binary API is not portable across platforms and compilation config. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary API is not portable across platforms and compilation configurations. We knew that, but it's worst than expected:
Ubuntu aarch64 != Ubuntu amd64 != CentOS amd64 != (Ubuntu amd64 + tsan) != Windows 10 != MacOS != ..., and it goes. It's unfortunate, but
rcutilscoverage still is above 95% so not a showstopper.CI up to
rcutils: