Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move stdatomic helper to rcutils #126

Merged
merged 3 commits into from
Nov 8, 2018
Merged

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Nov 8, 2018

We've discussed doing this a few times, but my most recent work required that I make this helper interface public in rcl (previously it was only used in the source part of rcl and the headers were not installed), so I thought I might as well move it to rcutils while making it public at the same time.

Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood added enhancement New feature or request in review Waiting for review (Kanban column) labels Nov 8, 2018
@wjwwood wjwwood self-assigned this Nov 8, 2018
@wjwwood
Copy link
Member Author

wjwwood commented Nov 8, 2018

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood
Copy link
Member Author

wjwwood commented Nov 8, 2018

CI after fixing the line length 💀:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood merged commit 3963a3e into master Nov 8, 2018
@wjwwood wjwwood deleted the move_stdatomic_helper_to_rcutils branch November 8, 2018 22:15
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants