Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Make sure that an existing path is a directory for create_directories" #96

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Revert "Make sure that an existing path is a directory for create_directories" #96

merged 1 commit into from
Sep 25, 2020

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Sep 24, 2020

Reverts #95

@christophebedard I'm reverting this because it is causing test failures in rosbag, see:

https://ci.ros2.org/job/ci_linux/12453/testReport/

I didn't run CI correctly so we didn't see the break.

@clalancette @jacobperron FYI

@wjwwood wjwwood requested a review from a team as a code owner September 24, 2020 21:26
@wjwwood wjwwood self-assigned this Sep 24, 2020
clalancette
clalancette approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now, with green CI. @christophebedard FYI.

@wjwwood
Copy link
Member Author

wjwwood commented Sep 24, 2020

CI using --pacakges-above-and-dependencies rcpputils:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood
Copy link
Member Author

wjwwood commented Sep 24, 2020

I messed up the arguments again... (had a typo)

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood merged commit ba5d1e4 into master Sep 25, 2020
@wjwwood wjwwood deleted the revert-95-fs-create-directories-check-if-dir branch September 25, 2020 03:31
fujitatomoya added a commit to fujitatomoya/rcpputils that referenced this pull request Sep 25, 2020
@fujitatomoya
Revert "Revert "Make sure that an existing path is a directory for cr…
315086b 
…eate_directories (ros2#95)" (ros2#96)"

This reverts commit ba5d1e4.
@fujitatomoya fujitatomoya mentioned this pull request Sep 25, 2020
Closed
fujitatomoya added a commit to fujitatomoya/rcpputils that referenced this pull request Sep 25, 2020
@fujitatomoya
Revert "Revert "Make sure that an existing path is a directory for cr…
e3d8dbc 
…eate_directories (ros2#95)" (ros2#96)"

This reverts commit ba5d1e4.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@christophebedard christophebedard mentioned this pull request Sep 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@wjwwood wjwwood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjwwood @clalancette