[WIP] Add mimick based patch() functionality. #92
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
| [](rcutils_allocator_t allocator) { | ||
| return rcutils_strdup("dummy_name", allocator); | ||
| }); | ||
| EXPECT_EQ("dummy_name", rcpputils::get_executable_name()); |
There was a problem hiding this comment.
EXPECT_EQ, as rcpputils::get_executable_name() returns an std::string.
|
|
||
| } // namespace rcpputils | ||
|
|
||
| #define RCPPUTILS_PATCH_IGNORE_OPERATOR(type, op) \ |
There was a problem hiding this comment.
I'm sure you'll add more info in comments, but what purpose does overloading these operators have? It's not clear from the macro name.
There was a problem hiding this comment.
For every argument type, a set of comparison operators must be defined (even if meaningless) or otherwise mimick's macro generated code won't compile. This macro attempts to be a handy way to generate these dummy overloads. Name is up for debate 😅
FWIW I tried to come up with a smarter mechanism to hide this but couldn't find a way.
| { | ||
|
|
||
| template<size_t N, typename SignatureT> | ||
| struct patch_traits; |
There was a problem hiding this comment.
For these structs, c++ style suggests using PascalCase yah?
There was a problem hiding this comment.
Fair enough. I tend to fallback to stl style whenever writing templates.
| #define RCPPUTILS_PATCH_TARGET(what, where) \ | ||
| (std::string(RCUTILS_STRINGIFY(where)) + "@" + (what)) | ||
|
|
||
| #define patch(what, where, with) \ |
There was a problem hiding this comment.
Your macro name is the same as your struct name, will that lead to confusion?
There was a problem hiding this comment.
Perhaps. I don't expect the base class being used directly, but we can rename it.
|
Based on ros2/rcutils#272 (comment), making |
|
Closing this PR. |
Spin off from ros2/rcutils#272. Still lacking documentation, opening for early review.