Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Create a default warning for qos incompatibility" #543

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Revert "Create a default warning for qos incompatibility" #543

merged 1 commit into from
Apr 16, 2020

Conversation

nuclearsandwich
Copy link
Member

Reverts #536 until test failures in ros2cli can be addressed.

FYI @ivanpauno as the reviewer of #536.

@nuclearsandwich nuclearsandwich merged commit d1c8f4d into master Apr 16, 2020
@nuclearsandwich nuclearsandwich deleted the revert-536-emersonknapp/default-incompatible-qos-callback branch April 16, 2020 03:13
mm318 added a commit to ross-desmond/rclpy that referenced this pull request Apr 16, 2020
@mm318
Revert "Revert "Create a default warning for qos incompatibility" (ro…
6622fd3 
…s2#543)"

This reverts commit d1c8f4d.
@mm318 mm318 mentioned this pull request Apr 16, 2020
Merged
@ivanpauno
Copy link
Member

Thanks for reverting @nuclearsandwich !

mm318 added a commit to ross-desmond/rclpy that referenced this pull request Apr 16, 2020
@mm318
Revert "Revert "Create a default warning for qos incompatibility" (ro…
b47160d 
…s2#543)"

This reverts commit d1c8f4d.

Signed-off-by: Miaofei <miaofei@amazon.com>
mm318 added a commit to ross-desmond/rclpy that referenced this pull request Apr 17, 2020
@mm318
Revert "Revert "Create a default warning for qos incompatibility" (ro…
a988c01 
…s2#543)"

This reverts commit d1c8f4d.

Signed-off-by: Miaofei <miaofei@amazon.com>
ivanpauno pushed a commit that referenced this pull request Apr 17, 2020
@mm318
Revert "Revert "Create a default warning for qos incompatibility"" (#544
b8209da 
)

* Revert "Revert "Create a default warning for qos incompatibility" (#543)"

This reverts commit d1c8f4d.

Signed-off-by: Miaofei <miaofei@amazon.com>

* remove warning message from failing to register default callback

Signed-off-by: Miaofei <miaofei@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuclearsandwich @ivanpauno @emersonknapp