Ensure logging is initialized only once #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
approved these changes
Mar 4, 2020
ivanpauno
force-pushed
the
ivanpauno/move-logging-configure-fini-to-upper-layer
branch
from
699bf4b
to
0d9c49c
Compare
|
Rebased after #497 went in. |
|
CI jobs in ros2/rcl#579 (comment). |
fujitatomoya
approved these changes
Mar 6, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno
force-pushed
the
ivanpauno/move-logging-configure-fini-to-upper-layer
branch
from
0d9c49c
to
da86a77
Compare
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
hidmic
approved these changes
Apr 23, 2020
delete-merged-branch
bot
deleted the
ivanpauno/move-logging-configure-fini-to-upper-layer
branch
wjwwood
reviewed
May 20, 2021
| @@ -73,6 +85,7 @@ def shutdown(self): | |||
| with self._handle as capsule, self._lock: | |||
| rclpy_implementation.rclpy_shutdown(capsule) | |||
| self._call_on_shutdown_callbacks() | |||
| self._logging_fini() | |||
There was a problem hiding this comment.
@ivanpauno any idea why this is not called from try_shutdown() as well?
There was a problem hiding this comment.
no, I guess that was only a mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rcl#579.
Connects to ros2/rclcpp#998.