Don't wrap QoS Event callback argument in a list #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Please reference the original PR. I assume this part is not covered by any tests atm? |
|
Updated the description. Correct, it's not covered by any tests right now. I'll add one to this change - no sense allowing future regression. |
|
@thomas-moulard Please run CI for this. I would rather get the fix merged without a test before releasing new versions today. The test can be added in a follow up PR. |
|
Ack. I'm on it |
|
@thomas-moulard |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a mistake introduced in a review feedback on the original PR #316
Signed-off-by: Emerson Knapp eknapp@amazon.com