Parameter handling improvements. #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2019 18:14
- Adding set_descriptor. - Using better optional parameters for declare_parameters. - Handling read-only parameters. Signed-off-by: Juan Ignacio Ubeira <jubeira@ekumenlabs.com>
Signed-off-by: Juan Ignacio Ubeira <jubeira@ekumenlabs.com>
wjwwood
reviewed
May 13, 2019
I don't think it is necessary. It just looked more consistent. |
|
CI:
@wjwwood Errors look unrelated; I think we can proceed with this one. |
|
Thanks @jubeira! |
This was referenced May 23, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #341.
There are some details that still need a bit of attention (see #341 (comment)). The PR includes a proposal for
set_descriptoras described in the comment.On the other hand, I'd like some input about the optional signature using
Parameteras input fordeclare_parameter(see comment). Is it worth implementing it even if it only applies todeclare_parameterbut notdeclare_parameters?Other than that, this should be ready for an initial review.