Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node graph functions #247

Merged
merged 8 commits into from
Dec 7, 2018
Merged

Add node graph functions #247

merged 8 commits into from
Dec 7, 2018

Conversation

ross-desmond
Copy link
Contributor

@ross-desmond ross-desmond commented Nov 16, 2018 •
edited by mjcarroll
Loading

Summary: Add node graph calls to Node class in ros2 python

Connects to ros2/rcl#333

@tfoote tfoote added the in review Waiting for review (Kanban column) label Nov 16, 2018
@ross-desmond
Copy link
Contributor Author

Connected to rcl

@ross-desmond ross-desmond mentioned this pull request Nov 20, 2018
Closed
34 tasks
@thomas-moulard
Copy link
Contributor

@ross-desmond PTAL at https://github.com/thomas-moulard/rclpy/tree/node_graph_impl - this fixes flake8 issues.

@thomas-moulard
Copy link
Contributor

Verified that tests are passing locally.

@ross-desmond
Copy link
Contributor Author

CI build failing due to 0.6.0 tag.

clalancette
clalancette approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed one more small potential leak in the error case. This code now looks OK to me once we get green CI.

@ross-desmond
Copy link
Contributor Author

@clalancette Thanks!

@jacobperron jacobperron merged commit e173ccd into ros2:master Dec 7, 2018
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Dec 7, 2018
@brawner brawner mentioned this pull request Feb 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ross-desmond @thomas-moulard @clalancette @tfoote @jacobperron @mm318