Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "use test_msgs instead of std_msgs" #207

Closed
wants to merge 1 commit into from

Conversation

mikaelarguedas
Copy link
Member

Reverts #204

My bad I was holding #204 to cut the release from master and fast forward it to the bouncy branch before merging...
So I'm reverting #204, cutting the release and then will reapply it.

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Jul 17, 2018
@sloretz
Copy link
Contributor

sloretz commented Jul 17, 2018

Since this only changes tests and a <test_depend>, would it be harmless to include this in the patch release?

@mikaelarguedas
Copy link
Member Author

it should not be impactful for users. It just doesn't "need" to be backported but should be fine to keep it as part of the patch release

@mikaelarguedas
Copy link
Member Author

closing this then and cutting the release with the current state from master

@mikaelarguedas mikaelarguedas deleted the revert-204-use_test_msgs branch July 17, 2018 19:00
@mikaelarguedas mikaelarguedas removed the in progress Actively being worked on (Kanban column) label Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants