Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use test_msgs instead of std_msgs #204

Merged
merged 1 commit into from
Jul 17, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rclpy/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<test_depend>ament_lint_common</test_depend>
<test_depend>rcl_interfaces</test_depend>
<test_depend>rosidl_generator_py</test_depend>
<test_depend>std_msgs</test_depend>
<test_depend>test_msgs</test_depend>

<export>
<build_type>ament_cmake</build_type>
Expand Down
6 changes: 3 additions & 3 deletions rclpy/test/test_callback_group.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import rclpy
from rclpy.callback_groups import MutuallyExclusiveCallbackGroup
from rclpy.callback_groups import ReentrantCallbackGroup
from std_msgs.msg import String
from test_msgs.msg import Primitives


class TestCallbackGroup(unittest.TestCase):
Expand Down Expand Up @@ -70,10 +70,10 @@ def test_create_timer_with_group(self):
self.assertTrue(group.has_entity(tmr2))

def test_create_subscription_with_group(self):
sub1 = self.node.create_subscription(String, 'chatter', lambda msg: print(msg))
sub1 = self.node.create_subscription(Primitives, 'chatter', lambda msg: print(msg))
group = ReentrantCallbackGroup()
sub2 = self.node.create_subscription(
String, 'chatter', lambda msg: print(msg), callback_group=group)
Primitives, 'chatter', lambda msg: print(msg), callback_group=group)

self.assertFalse(group.has_entity(sub1))
self.assertTrue(group.has_entity(sub2))
Expand Down
12 changes: 7 additions & 5 deletions rclpy/test/test_destruction.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,22 +98,24 @@ def func_destroy_timers():

def func_destroy_entities():
import rclpy
from std_msgs.msg import Int16, Float32, String, UInt8
from test_msgs.msg import Primitives
rclpy.init()

node = rclpy.create_node('test_node4')

timer = node.create_timer(0.1, None)
timer # noqa
assert 1 == len(node.timers)
pub1 = node.create_publisher(Int16, 'pub1_topic')
pub1 = node.create_publisher(Primitives, 'pub1_topic')
assert 1 == len(node.publishers)
pub2 = node.create_publisher(Float32, 'pub2_topic')
pub2 = node.create_publisher(Primitives, 'pub2_topic')
pub2 # noqa
assert 2 == len(node.publishers)
sub1 = node.create_subscription(String, 'sub1_topic', lambda msg: print('Received %r' % msg))
sub1 = node.create_subscription(
Primitives, 'sub1_topic', lambda msg: print('Received %r' % msg))
assert 1 == len(node.subscriptions)
sub2 = node.create_subscription(UInt8, 'sub2_topic', lambda msg: print('Received %r' % msg))
sub2 = node.create_subscription(
Primitives, 'sub2_topic', lambda msg: print('Received %r' % msg))
sub2 # noqa
assert 2 == len(node.subscriptions)

Expand Down
24 changes: 12 additions & 12 deletions rclpy/test/test_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import rclpy
from rclpy.exceptions import InvalidServiceNameException
from rclpy.exceptions import InvalidTopicNameException
from std_msgs.msg import String
from test_msgs.msg import Primitives

TEST_NODE = 'my_node'
TEST_NAMESPACE = '/my_ns'
Expand All @@ -44,22 +44,22 @@ def test_accessors(self):
self.assertEqual(self.node.get_namespace(), TEST_NAMESPACE)

def test_create_publisher(self):
self.node.create_publisher(String, 'chatter')
self.node.create_publisher(Primitives, 'chatter')
with self.assertRaisesRegex(InvalidTopicNameException, 'must not contain characters'):
self.node.create_publisher(String, 'chatter?')
self.node.create_publisher(Primitives, 'chatter?')
with self.assertRaisesRegex(InvalidTopicNameException, 'must not start with a number'):
self.node.create_publisher(String, '/chatter/42_is_the_answer')
self.node.create_publisher(Primitives, '/chatter/42_is_the_answer')
with self.assertRaisesRegex(ValueError, 'unknown substitution'):
self.node.create_publisher(String, 'chatter/{bad_sub}')
self.node.create_publisher(Primitives, 'chatter/{bad_sub}')

def test_create_subscription(self):
self.node.create_subscription(String, 'chatter', lambda msg: print(msg))
self.node.create_subscription(Primitives, 'chatter', lambda msg: print(msg))
with self.assertRaisesRegex(InvalidTopicNameException, 'must not contain characters'):
self.node.create_subscription(String, 'chatter?', lambda msg: print(msg))
self.node.create_subscription(Primitives, 'chatter?', lambda msg: print(msg))
with self.assertRaisesRegex(InvalidTopicNameException, 'must not start with a number'):
self.node.create_subscription(String, '/chatter/42ish', lambda msg: print(msg))
self.node.create_subscription(Primitives, '/chatter/42ish', lambda msg: print(msg))
with self.assertRaisesRegex(ValueError, 'unknown substitution'):
self.node.create_subscription(String, 'foo/{bad_sub}', lambda msg: print(msg))
self.node.create_subscription(Primitives, 'foo/{bad_sub}', lambda msg: print(msg))

def test_create_client(self):
self.node.create_client(GetParameters, 'get/parameters')
Expand Down Expand Up @@ -99,15 +99,15 @@ def test_count_publishers_subscribers(self):
self.assertEqual(0, self.node.count_publishers(fq_topic_name))
self.assertEqual(0, self.node.count_subscribers(fq_topic_name))

self.node.create_publisher(String, short_topic_name)
self.node.create_publisher(Primitives, short_topic_name)
self.assertEqual(1, self.node.count_publishers(short_topic_name))
self.assertEqual(1, self.node.count_publishers(fq_topic_name))

self.node.create_subscription(String, short_topic_name, lambda msg: print(msg))
self.node.create_subscription(Primitives, short_topic_name, lambda msg: print(msg))
self.assertEqual(1, self.node.count_subscribers(short_topic_name))
self.assertEqual(1, self.node.count_subscribers(fq_topic_name))

self.node.create_subscription(String, short_topic_name, lambda msg: print(msg))
self.node.create_subscription(Primitives, short_topic_name, lambda msg: print(msg))
self.assertEqual(2, self.node.count_subscribers(short_topic_name))
self.assertEqual(2, self.node.count_subscribers(fq_topic_name))

Expand Down