Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options-struct interfaces for creating publishers/subscribers (pre-QoS, standalone) #673

Merged
merged 5 commits into from
Apr 12, 2019
Merged

Options-struct interfaces for creating publishers/subscribers (pre-QoS, standalone) #673

merged 5 commits into from
Apr 12, 2019

Commits on Apr 9, 2019

  1. Options-based create_publisher and create_subscription interfaces 

    Introduce new Options structs for creating publishers and subscribers. Deprecate existing interfaces for checking in CI how often they are used.

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
    Emerson Knapp committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    6f4e332 View commit details
    Browse the repository at this point in the history

  2. Remove default params that resulted in ambiguous declarations. 

    Signed-off-by: Emerson Knapp <eknapp@amazon.com>
    Emerson Knapp committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    c718b56 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. Remove one deprecation to limit upstream impact, add documentation on… 

    … pub/sub options, slim down test lambdas character count

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
    Emerson Knapp committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    0ba1911 View commit details
    Browse the repository at this point in the history

  2. Un-abbreviate Allocator in new interfaces/types, define a common Opti… 

    …ons specialization that doesn't need empty brackets

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
    Emerson Knapp committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    4884617 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. Suppress cppcheck syntaxError for the one function 

    Signed-off-by: Emerson Knapp <eknapp@amazon.com>
    Emerson Knapp committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    a60c03e View commit details
    Browse the repository at this point in the history