Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rclcpp_action Server implementation #593

Merged
merged 71 commits into from
Dec 6, 2018
Merged

rclcpp_action Server implementation #593

merged 71 commits into from
Dec 6, 2018

Commits on Dec 5, 2018

  1. Commiting to back up work, does not function

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    5ffe3e8 View commit details
    Browse the repository at this point in the history

  2. Can call user callback when goal request received

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    0967eda View commit details
    Browse the repository at this point in the history

  3. fini action server in destructor

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    c2338f0 View commit details
    Browse the repository at this point in the history

  4. rename user callback virtual functions

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    8854af3 View commit details
    Browse the repository at this point in the history

  5. handle_execute test passes

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    f752de0 View commit details
    Browse the repository at this point in the history

  6. Remove out of date comment

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    6962024 View commit details
    Browse the repository at this point in the history

  7. Refactor execute into three functions

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    5a4cc1b View commit details
    Browse the repository at this point in the history

  8. Remove unused file

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    9e5d0d6 View commit details
    Browse the repository at this point in the history

  9. Add failing cancel test

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    36c3825 View commit details
    Browse the repository at this point in the history

  10. Cancel test passes

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    c508c6d View commit details
    Browse the repository at this point in the history

  11. Remove out of date comments

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    6e603e9 View commit details
    Browse the repository at this point in the history

  12. Make sure server publishes status when accepting a goal

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    9565203 View commit details
    Browse the repository at this point in the history

  13. Send status when goals transition to cancelling

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    d33fe65 View commit details
    Browse the repository at this point in the history

  14. Refactored sending goal request to its own function

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    f795ca8 View commit details
    Browse the repository at this point in the history

  15. Refactor cancel request into it's own function

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    387701d View commit details
    Browse the repository at this point in the history

  16. Comment with remaining tests

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    ec7f1eb View commit details
    Browse the repository at this point in the history

  17. Executing and terminal state statuses

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    04de5f4 View commit details
    Browse the repository at this point in the history

  18. publish feedback works

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    e1d1006 View commit details
    Browse the repository at this point in the history

  19. server sends result to clients that request it

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    20fe2ac View commit details
    Browse the repository at this point in the history

  20. Remove out of date comment

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    8dc5b84 View commit details
    Browse the repository at this point in the history

  21. Add ServerGoalHandle::is_active()

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    4a9819d View commit details
    Browse the repository at this point in the history

  22. Cleanup when goals expire

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    a2c06a4 View commit details
    Browse the repository at this point in the history

  23. Can pass in action server options

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    da520be View commit details
    Browse the repository at this point in the history

  24. cpplint and uncrustify fixes

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    199d015 View commit details
    Browse the repository at this point in the history

  25. Fix clang warnings

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    586b861 View commit details
    Browse the repository at this point in the history

  26. Copy rcl goal handle

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    d03e651 View commit details
    Browse the repository at this point in the history

  27. Fix clang warning

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    ef65970 View commit details
    Browse the repository at this point in the history

  28. Use intermediate value to avoid left shift on 32bit integer

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    48c951d View commit details
    Browse the repository at this point in the history

  29. RCLCPP_ACTION_PUBLIC everwhere

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    283e39f View commit details
    Browse the repository at this point in the history

  30. Change callback parameter from C type to C++

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    a13933a View commit details
    Browse the repository at this point in the history

  31. Add accessors for request and uuid

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    06d3842 View commit details
    Browse the repository at this point in the history

  32. Feedback must include goal id

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    eac6ddd View commit details
    Browse the repository at this point in the history

  33. Document Server<> and ServerBase<>

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    4038b15 View commit details
    Browse the repository at this point in the history

  34. handle_execute -> handle_accepted

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    0606831 View commit details
    Browse the repository at this point in the history

  35. Test deferred execution

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    5922b59 View commit details
    Browse the repository at this point in the history

  36. only publish feedback if goal is executing

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    8a4c4cf View commit details
    Browse the repository at this point in the history

  37. Documentation for ServerGoalHandle

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    e75ce64 View commit details
    Browse the repository at this point in the history

  38. document msg parameters

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    ff542aa View commit details
    Browse the repository at this point in the history

  39. remove unnecessary fini

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    0005862 View commit details
    Browse the repository at this point in the history

  40. notify_goal_done only takes server

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    40b5dbd View commit details
    Browse the repository at this point in the history

  41. Use unique_indentifier_msgs

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    994539f View commit details
    Browse the repository at this point in the history

  42. create_server accepts group and removes waitable

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    057afa9 View commit details
    Browse the repository at this point in the history

  43. uncrustify

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    3405077 View commit details
    Browse the repository at this point in the history

  44. Use weak ptr to avoid crash if goal handle lives longer than server

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    a0a1a91 View commit details
    Browse the repository at this point in the history

  45. Handle goal callback const message

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    2965274 View commit details
    Browse the repository at this point in the history

  46. Goal handle doesn't have server pointer anymore

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    1003eed View commit details
    Browse the repository at this point in the history

  47. Lock goal_handles_ on Server<>

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    379459f View commit details
    Browse the repository at this point in the history

  48. rcl_action_server_t protected with mutex

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    2085366 View commit details
    Browse the repository at this point in the history

  49. ServerBase results protected with mutex

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    4664398 View commit details
    Browse the repository at this point in the history

  50. protect rcl goal handle with mutex

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    48a709e View commit details
    Browse the repository at this point in the history

  51. is_cancel_request -> is_canceling

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    e54b8a5 View commit details
    Browse the repository at this point in the history

  52. Add missing include

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    69fba0c View commit details
    Browse the repository at this point in the history

  53. use GoalID and change uuid -> goal_id

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    c3f1ec6 View commit details
    Browse the repository at this point in the history

  54. Keep rcl goal handle alive until it expires on server

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    1c36fb8 View commit details
    Browse the repository at this point in the history

  55. uncrustify

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    63eff6c View commit details
    Browse the repository at this point in the history

  56. Move UUID hash

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    054b818 View commit details
    Browse the repository at this point in the history

  57. Log messages in server

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    ac82e36 View commit details
    Browse the repository at this point in the history

  58. ACTION -> ActionT

    @sloretz
    sloretz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    ad570dc View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2018

  1. Cancel abandoned goal handles

    @sloretz
    sloretz committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    ec70b67 View commit details
    Browse the repository at this point in the history

  2. Add convert() for C and C++ goal id

    @sloretz
    sloretz committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    f717e9b View commit details
    Browse the repository at this point in the history

  3. Remove unused variable

    @sloretz
    sloretz committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    03c9cf0 View commit details
    Browse the repository at this point in the history

  4. Constant reference

    @sloretz
    sloretz committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    ea33c88 View commit details
    Browse the repository at this point in the history

  5. Move variable declaration down

    @sloretz
    sloretz committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    8a21dec View commit details
    Browse the repository at this point in the history

  6. is_ready if goal expired

    @sloretz
    sloretz committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    bf4797a View commit details
    Browse the repository at this point in the history

  7. map[] default constructs if it doesn't exist

    @sloretz
    sloretz committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    ae676d8 View commit details
    Browse the repository at this point in the history

  8. Use rcl_action_get_goal_status_array()

    @sloretz
    sloretz committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    039854d View commit details
    Browse the repository at this point in the history

  9. Array -> GoalID

    @sloretz
    sloretz committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    71c7100 View commit details
    Browse the repository at this point in the history

  10. Use reentrant mutex for everything

    @sloretz
    sloretz committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    b7a3de1 View commit details
    Browse the repository at this point in the history

  11. comment

    @sloretz
    sloretz committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    de1510b View commit details
    Browse the repository at this point in the history

  12. scope exit to fini cancel response

    @sloretz
    sloretz committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    1c8c86d View commit details
    Browse the repository at this point in the history

  13. using GoalID

    @sloretz
    sloretz committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    9ec3f39 View commit details
    Browse the repository at this point in the history