Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SignalHandler get_global_signal_handler to avoid complex types in static memory (backport #2316) #2321

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Update SignalHandler get_global_signal_handler to avoid complex types in static memory (backport #2316) #2321

merged 1 commit into from
Oct 4, 2023

Commits on Sep 30, 2023

  1. Update SignalHandler get_global_signal_handler to avoid complex types… 

    … in static memory (#2316)

* Update SignalHandler get_global_signal_handler to avoid complex types in static memory

This was flagged by msan as a problem.

There's a description of why this is a potential problem here: https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

Signed-off-by: Tully Foote <tullyfoote@intrinsic.ai>
Co-authored-by: William Woodall <william+github@osrfoundation.org>
(cherry picked from commit 7c1143d)
    @tfoote @mergify
    tfoote authored and mergify[bot] committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    0677d3b View commit details
    Browse the repository at this point in the history