Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp list_parameters to be more efficient and easier to read. #2282

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Revamp list_parameters to be more efficient and easier to read. #2282

merged 1 commit into from
Aug 23, 2023

Commits on Aug 22, 2023

  1. Revamp list_parameters to be more efficient and easier to read. 

    1. Use constref for the loop variable.
2. Do more work outside of the loop.
3. Skip doing unnecessary work where we can inside the loop.

With this in place, I measured about a 7% performance
improvement over the previous implementation.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    8be74b4 View commit details
    Browse the repository at this point in the history