Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Rate to select the clock to work with #2123

Merged
merged 18 commits into from
Aug 31, 2023
Merged

Make Rate to select the clock to work with #2123

merged 18 commits into from
Aug 31, 2023

Commits on Aug 25, 2023

  1. Make Rate to select the clock to work with 

    Add ROSRate respective with ROS time

Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov
    AlexeyMerzlyakov committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    68de228 View commit details
    Browse the repository at this point in the history

  2. Make GenericRate class to be deprecated 

    Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov
    AlexeyMerzlyakov committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    88e6d05 View commit details
    Browse the repository at this point in the history

  3. Adjust test cases for new rates 

    Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov
    AlexeyMerzlyakov committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    4237956 View commit details
    Browse the repository at this point in the history

  4. Fix GenericRate API to remain the same 

    Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov
    AlexeyMerzlyakov committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    ac35e54 View commit details
    Browse the repository at this point in the history

  5. Return back GenericRate logic 

    Correct Rate::sleep() return value

Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov
    AlexeyMerzlyakov committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    76d7c44 View commit details
    Browse the repository at this point in the history

  6. Restore back RateBase -> GenericRate relationship 

    is_steady() to be deprecated

Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov
    AlexeyMerzlyakov committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    beb00b1 View commit details
    Browse the repository at this point in the history

  7. Move Rate implementations to rate.cpp 

    Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov
    AlexeyMerzlyakov committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    112b7b7 View commit details
    Browse the repository at this point in the history

  8. Add checks for incorrect Rate constructor arguments 

    Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov
    AlexeyMerzlyakov committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    8f19f28 View commit details
    Browse the repository at this point in the history

  9. Cover GenericRate::get_type() functionality 

    Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov
    AlexeyMerzlyakov committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    188b8dd View commit details
    Browse the repository at this point in the history

  10. Fix uncrustify errors 

    Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov
    AlexeyMerzlyakov committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    7c1a331 View commit details
    Browse the repository at this point in the history

  11. Misprint fix 

    Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov
    AlexeyMerzlyakov committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    5c3cec8 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Separate Rate constructors implementations 

    Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov
    AlexeyMerzlyakov committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    a947972 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Update rclcpp/include/rclcpp/rate.hpp 

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov @clalancette
    AlexeyMerzlyakov and clalancette committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    480681a View commit details
    Browse the repository at this point in the history

  2. Update rclcpp/include/rclcpp/rate.hpp 

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov @clalancette
    AlexeyMerzlyakov and clalancette committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    99b6d07 View commit details
    Browse the repository at this point in the history

  3. Update rclcpp/include/rclcpp/rate.hpp 

    Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov @clalancette
    AlexeyMerzlyakov and clalancette committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    42c14dd View commit details
    Browse the repository at this point in the history

  4. Switch to RCLCPP_EXPECT_THROW_EQ in test_rate 

    Signed-off-by: Alexey Merzlyakov <alexey.merzlyakov@samsung.com>
    @AlexeyMerzlyakov
    AlexeyMerzlyakov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    6354c68 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Another try at Windows annotations. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    bff4fd0 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Fix compilation with clang. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    f54ca7d View commit details
    Browse the repository at this point in the history