Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a create_timer method to Node and LifecycleNode classes #1975

Merged
merged 24 commits into from
Aug 30, 2022
Merged

Add a create_timer method to Node and LifecycleNode classes #1975

merged 24 commits into from
Aug 30, 2022

Commits on Aug 25, 2022

  1. Add a create_timer method to the Node class 

    Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    efc08b7 View commit details
    Browse the repository at this point in the history

  2. Updated unit tests to check both wall timers and generic timers 

    Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    3b359ad View commit details
    Browse the repository at this point in the history

  3. Added a create_timer test for the newly-added function. 

    Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    45e6886 View commit details
    Browse the repository at this point in the history

  4. Try modifying the sim test to increment with rclcpp::Duration() to av… 

    …oid overflow

Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    9fd618f View commit details
    Browse the repository at this point in the history

  5. Update lifecycle node to also support create_timer 

    Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    e07fdd9 View commit details
    Browse the repository at this point in the history

  6. Uncrustify one file. 

    Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    ac4af54 View commit details
    Browse the repository at this point in the history

  7. Fix a test to use a create_timer when use_sim_time:=True 

    Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    8e23724 View commit details
    Browse the repository at this point in the history

  8. Fixed the timer tests that were calling create_wall_timer in TEST_P i… 

    …nstances.

Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    c587718 View commit details
    Browse the repository at this point in the history

  9. CI nondeterminism test ros2#1 

    Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    e3fffe2 View commit details
    Browse the repository at this point in the history

  10. CI nondeterminism test ros2#2 

    Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    2c7fe5c View commit details
    Browse the repository at this point in the history

  11. CI nondeterminism test ros2#3 

    Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    879a512 View commit details
    Browse the repository at this point in the history

  12. CI nondeterminism test ros2#4 

    Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    7a21ff3 View commit details
    Browse the repository at this point in the history

  13. CI nondeterminism test ros2#5 

    Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    59d32c3 View commit details
    Browse the repository at this point in the history

  14. Rename lambda function and update timeout duration. 

    Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    3f16cb2 View commit details
    Browse the repository at this point in the history

  15. Move from 10s -> 2s max check duration in test_time_source 

    Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    7d77162 View commit details
    Browse the repository at this point in the history

  16. Refactor create_timer to use shared_ptr and follow a predictable call… 

    … sequence

Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    af24d74 View commit details
    Browse the repository at this point in the history

  17. Include a missing header file 

    Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    b8338e8 View commit details
    Browse the repository at this point in the history

  18. Correct a time comparison in spin_until_time 

    Signed-off-by: Andrew Symington <andrew.c.symington@gmail.com>
    @asymingt @ivanpauno
    asymingt authored and ivanpauno committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    95afb7e View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. Revert "Refactor create_timer to use shared_ptr and follow a predicta… 

    …ble call sequence"

This reverts commit 3de6312.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    f05c81c View commit details
    Browse the repository at this point in the history

  2. Adjust create_timer() overloads, reuse code 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    a5c956c View commit details
    Browse the repository at this point in the history

  3. Comment out problematic test 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    2e6e4ff View commit details
    Browse the repository at this point in the history

  4. Please linters 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    1c16100 View commit details
    Browse the repository at this point in the history

  5. Fix rclcpp_lifecycle 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    2a9e6f6 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. nit 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    7e24c8d View commit details
    Browse the repository at this point in the history