Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RCLCPP_LIFECYCLE_PUBLIC visibility macro in rclcpp_lifecycle package #1732

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Use RCLCPP_LIFECYCLE_PUBLIC visibility macro in rclcpp_lifecycle package #1732

merged 1 commit into from
Jul 28, 2021

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jul 28, 2021

Fixes #1731

@sloretz
RCLCPP_PUBLIC -> RCLCPP_LIFECYCLE_PUBLIC
6ccd052 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added the bug Something isn't working label Jul 28, 2021
@sloretz sloretz self-assigned this Jul 28, 2021
@sloretz
Copy link
Contributor Author

sloretz commented Jul 28, 2021

CI (build: --packages-up-to rclcpp_lifecycle test: --packages-select rclcpp_lifecycle)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor Author

sloretz commented Jul 28, 2021

CI LGTM, merging!

@sloretz sloretz merged commit 01f6ebd into master Jul 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the for_each_callback_group_dll_linkage branch July 28, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

@Karsten1987 Karsten1987 Karsten1987 approved these changes

Assignees

@sloretz sloretz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Inconsistent dll linkage with for_each_callback_group
3 participants
@sloretz @wjwwood @Karsten1987