Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the interface for pre-shutdown callback #1714

Merged
merged 2 commits into from
Oct 30, 2021
Merged

Add the interface for pre-shutdown callback #1714

merged 2 commits into from
Oct 30, 2021

Commits on Oct 28, 2021

  1. Add the interface for pre-shutdown callback 

    Signed-off-by: Barry Xu <barry.xu@sony.com>
    @Barry-Xu-2018
    Barry-Xu-2018 authored and mergify-bot committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    9179245 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. Address review comments 

    1. Remove add_pre_shutdown_callback and remove_pre_shutdown_callback in utilities.hpp
2. Add RCLCPP_LOCAL
3. Fix uninitialized warning
4. Fix typo

Signed-off-by: Barry Xu <barry.xu@sony.com>
    @Barry-Xu-2018
    Barry-Xu-2018 committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    cd1cb56 View commit details
    Browse the repository at this point in the history