Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👩‍🌾 Disable test case that fails consistently on Windows #1443

Closed
wants to merge 1 commit into from
Closed

👩‍🌾 Disable test case that fails consistently on Windows #1443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rclcpp/test/rclcpp/executors/test_executors.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,9 @@ TYPED_TEST(TestExecutors, detachOnDestruction) {
// Currently fails for StaticSingleThreadedExecutor so it is being skipped, see:
// https://github.com/ros2/rclcpp/issues/1231
TYPED_TEST(TestExecutorsStable, addTemporaryNode) {
// Test failing on Windows Debug, see
// https://github.com/ros2/rclcpp/issues/1282
#if !defined(_WIN32)
using ExecutorType = TypeParam;
ExecutorType executor;

Expand All @@ -159,6 +162,7 @@ TYPED_TEST(TestExecutorsStable, addTemporaryNode) {
std::this_thread::sleep_for(50ms);
executor.cancel();
spinner.join();
#endif
}

// Check executor throws properly if the same node is added a second time
Expand Down