Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy backport] Backport unit tests for coverage into foxy #1397

Merged
merged 8 commits into from
Oct 9, 2020
Merged

[foxy backport] Backport unit tests for coverage into foxy #1397

merged 8 commits into from
Oct 9, 2020

Commits on Oct 9, 2020

  1. Improved test_subscription_options (#1358) 

    * Improved test_subscription_options

Signed-off-by: ahcorde <ahcorde@gmail.com>

* used RCLCPP_EXPECT_THROW_EQ in test_subcription_options

Signed-off-by: ahcorde <ahcorde@gmail.com>

* make linters happy

Signed-off-by: ahcorde <ahcorde@gmail.com>
    @ahcorde @brawner
    ahcorde authored and brawner committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    d3f3f35 View commit details
    Browse the repository at this point in the history

  2. Covered resolve_use_intra_process (#1359) 

    * Covered resolve_use_intra_process

Signed-off-by: ahcorde <ahcorde@gmail.com>

* used RCLCPP_EXPECT_THROW_EQ in test_subscription_throws_intraprocess

Signed-off-by: ahcorde <ahcorde@gmail.com>
    @ahcorde @brawner
    ahcorde authored and brawner committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    de29374 View commit details
    Browse the repository at this point in the history

  3. Improved test publisher - zero qos history depth value exception (#1360) 

    Signed-off-by: ahcorde <ahcorde@gmail.com>
    @ahcorde @brawner
    ahcorde authored and brawner committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    e2824b1 View commit details
    Browse the repository at this point in the history

  4. Minor fixes to the parameter_service.cpp file. 

    Make sure to #include what is used, and also fix a typo
in a test.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette @brawner
    clalancette authored and brawner committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    81e677b View commit details
    Browse the repository at this point in the history

  5. Add in additional tests for parameter_client.cpp coverage. 

    This gets us to 96% line coverage.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette @brawner
    clalancette authored and brawner committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    1aed178 View commit details
    Browse the repository at this point in the history

  6. Add timer coverage tests (#1363) 

    * Add missing tests API
* Reformat style error throw
* Add internal errors tests

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545 @brawner
    Blast545 authored and brawner committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    d145d9c View commit details
    Browse the repository at this point in the history

  7. Add time API coverage tests (#1347) 

    * Change value used as max representation
* Add coverage tests time
* Add call to detach clock
* Add tests time
* Add duration construction tests
* Add const qualifier to constants
* Add check clock stays the same
* Make operator RCLCPP_PUBLIC
* Add tests exceptions duration
* Fix division by 0 on windows

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
    @Blast545 @brawner
    Blast545 authored and brawner committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    98b457f View commit details
    Browse the repository at this point in the history

  8. Add test for ParameterService (#1355) 

    * Add test for ParameterService

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Address PR feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>
    @brawner
    brawner committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    741c6af View commit details
    Browse the repository at this point in the history