Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foxy backport] Add coverage for service and client API (#1332, #1329) #1394

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Oct 8, 2020

This backports #1332 and #1329 for foxy. This will be rebase and merged into #1383 for final staging before rebase and merging onto foxy.

@brawner brawner requested a review from ahcorde October 8, 2020 22:06
@brawner
Copy link
Contributor Author

brawner commented Oct 8, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add coverage for client API

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner force-pushed the brawner/rclcpp-backport-tests-part6 branch from b8f69f5 to 34b79f0 Compare October 9, 2020 17:52
@brawner brawner changed the base branch from brawner/rclcpp-backport-tests-part5 to brawner/rclcpp-backport-tests-part1 October 9, 2020 17:52
@brawner brawner merged commit 9e59de0 into brawner/rclcpp-backport-tests-part1 Oct 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/rclcpp-backport-tests-part6 branch October 9, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants