Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rclcpp_action.test_client is flaky #744

Closed
jacobperron opened this issue May 28, 2019 · 1 comment
Closed

rclcpp_action.test_client is flaky #744

jacobperron opened this issue May 28, 2019 · 1 comment
Assignees
@jacobperron
Labels
bug Something isn't working

Comments

@jacobperron
Copy link
Member

jacobperron commented May 28, 2019 •
edited
Loading

Bug report

Required Info:

  • Operating System:
    • Ubuntu 18.04
  • Installation type:
    • source
  • Version or commit hash:
  • DDS implementation:
    • Fast-RTPS
  • Client library (if applicable):
    • rclcpp

Steps to reproduce issue

With the latest source checked out:

colcon build --packages-up-to rclcpp_action
colcon test --packages-select rclcpp_action --retest-until-fail 10

Expected behavior

Build and tests without error.

Actual behavior

No test results for rclcpp_action.test_client:

build/rclcpp_action/test_results/rclcpp_action/test_client.gtest.xml: 1 test, 0 errors, 1 failure, 0 skipped
- rclcpp_action test_client.gtest.missing_result
  <<< failure message
    The test did not generate a result file.
  >>>

Additional information

This is also happening on aarch64 builds, which I noticed here: https://ci.ros2.org/job/ci_linux-aarch64/3428/testReport/.
@jacobperron jacobperron added the bug Something isn't working label May 28, 2019
@jacobperron
Copy link
Member Author

I haven't been able to reproduce the test failure.

I've looked through the test code and found that the tear-down method of the test fixture wasn't being called (#787), but I'm not sure this has anything to do with the flaky test.

nnmm pushed a commit to ApexAI/rclcpp that referenced this issue Jul 9, 2022
@Blast545
Add cov tests 95% (ros2#744)
626c82d 
* Add mocking tools
* Add mocked tests fail init/fini
* Reformat tests with helper macro
* Add nullptr/invalid tests
* Add domain_id mocked tests
* Add mimick support for test_log_level
* Add fini/ini tests log_level
* Add fini nullptr test
* Add mocked tests rmw_impl_id_check
* Add tests log_level
* Add bad_alloc test
* Add ini/fini for size 0
* Add tests add_logger_setting
* Add tests logger_settings
* Remove extra deallocation
* Replace allocation with captured rcutils_strdup

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this issue Aug 5, 2022
@clalancette
Include utility to quiet cpplint. (ros2#744)
1712a45 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobperron jacobperron

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacobperron