document and test rclcpp::Node::list_parameters

[wjwwood]

As a follow up of #495 (the method has existed for a long time, but I just didn't have time to fix it up in that pr), we need to still document and test the rclcpp::Node::list_parameters method.

[CursedRock17]

It seems that pull request #1342 solved the tests for this function, is there any need for the documentation to be updated?

[fujitatomoya]

@CursedRock17 i think the rest of the work here is

rclcpp/rclcpp/include/rclcpp/node.hpp

Line 975 in 9284d7c

* \todo: properly document and test this method.

[CursedRock17]

@fujitatomoya I did see that, but it was added in this commit in April 2019, whereas the pull request to "fix this" was added in September 2020. That being said, if there's still not enough documentation/testing around list_parameters I can still work on it. Although, there's a whole test here for list_parameter which should be enough.

[fujitatomoya]

@CursedRock17 i think tests have been added with list_parameters but still doc section is not well described? that is what i mean here.

rclcpp/rclcpp/include/rclcpp/node.hpp

Line 975 in 9284d7c

* \todo: properly document and test this method.

so adding documentation is the rest of the work here? what do you think?

[CursedRock17]

That's fair there's not much documentation there, do you mind if I make a pull request for this?

[fujitatomoya]

Please go for it, happy to do review 👍

[CursedRock17]

This can probably be closed now.