Virtual destructors (#212)

ros2 · Apr 25, 2016 · 6adfb91 · 6adfb91
1 parent e961189
commit 6adfb91
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/rclcpp/include/rclcpp/client.hpp b/rclcpp/include/rclcpp/client.hpp
@@ -51,7 +51,7 @@ class ClientBase
     const std::string & service_name);
 
   RCLCPP_PUBLIC
-  ~ClientBase();
+  virtual ~ClientBase();
 
   RCLCPP_PUBLIC
   const std::string &

diff --git a/rclcpp/include/rclcpp/node.hpp b/rclcpp/include/rclcpp/node.hpp
@@ -80,7 +80,7 @@ class Node
     bool use_intra_process_comms = false);
 
   RCLCPP_PUBLIC
-  ~Node();
+  virtual ~Node();
 
   /// Get the name of the node.
   // \return The name of the node.

diff --git a/rclcpp/include/rclcpp/publisher.hpp b/rclcpp/include/rclcpp/publisher.hpp
@@ -67,7 +67,7 @@ class PublisherBase
     size_t queue_size);
 
   RCLCPP_PUBLIC
-  ~PublisherBase();
+  virtual ~PublisherBase();
 
   /// Get the topic that this publisher publishes on.
   // \return The topic name.

diff --git a/rclcpp/include/rclcpp/service.hpp b/rclcpp/include/rclcpp/service.hpp
@@ -47,7 +47,7 @@ class ServiceBase
     const std::string service_name);
 
   RCLCPP_PUBLIC
-  ~ServiceBase();
+  virtual ~ServiceBase();
 
   RCLCPP_PUBLIC
   std::string