Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify storing of current_time. #850

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Clarify storing of current_time. #850

merged 1 commit into from
Nov 6, 2020

Commits on Nov 2, 2020

  1. Clarify storing of current_time. 

    clang static analysis (incorrectly) assumes that the value
of "storage->active" can change between the first and second
branch statements.  While we know that isn't actually true,
it is more clear and the same amount of code to just have
the branch once.  Rearrange the code here so that we collapse
all of the storage->active parts into one if block.

There should be no functional change with this.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    89366c3 View commit details
    Browse the repository at this point in the history