Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convenient node method to get a final topic/service name #835

Merged
merged 17 commits into from
Oct 19, 2020
Merged

Add convenient node method to get a final topic/service name #835

merged 17 commits into from
Oct 19, 2020

Commits on Oct 16, 2020

  1. Add resolve topic name 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    9d9d30e View commit details
    Browse the repository at this point in the history

  2. Use it in subscription init 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    b3db324 View commit details
    Browse the repository at this point in the history

  3. Even more convenient 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    1fa0952 View commit details
    Browse the repository at this point in the history

  4. Use it in publisher init 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    f61e1dd View commit details
    Browse the repository at this point in the history

  5. Adapt to services and clients 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    15f6c34 View commit details
    Browse the repository at this point in the history

  6. bugs 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    0930346 View commit details
    Browse the repository at this point in the history

  7. More fixes 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    48ff463 View commit details
    Browse the repository at this point in the history

  8. More test fixes 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    45731fa View commit details
    Browse the repository at this point in the history

  9. Another cleanup 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    d4fe429 View commit details
    Browse the repository at this point in the history

  10. Make test_client pass 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    acf705d View commit details
    Browse the repository at this point in the history

  11. Test for rcl_node_resolve_name 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    2965e3a View commit details
    Browse the repository at this point in the history

  12. Add new tests 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    6b04c49 View commit details
    Browse the repository at this point in the history

  13. fix 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    b708b3a View commit details
    Browse the repository at this point in the history

  14. Readd only expand, can be useful in rclcpp 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    4af74fc View commit details
    Browse the repository at this point in the history

  15. please linters 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    e296b8c View commit details
    Browse the repository at this point in the history

  16. nit 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Jacob Perron <jacob@openrobotics.org>
    @ivanpauno @jacobperron
    ivanpauno and jacobperron authored Oct 16, 2020
    Configuration menu
    Copy the full SHA
    a94f2db View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. Memory safety 101 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    84681f1 View commit details
    Browse the repository at this point in the history