Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport Foxy] Increased RCL coverage #826

Merged
merged 8 commits into from
Oct 16, 2020
Merged

[Backport Foxy] Increased RCL coverage #826

merged 8 commits into from
Oct 16, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 8, 2020

hidmic and others added 8 commits October 8, 2020 10:27
@hidmic @ahcorde
Improve enclave validation test coverage. (#682)
4965901 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @ahcorde
Improve clock test coverage. (#685)
41dbf4e 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @ahcorde
Minor fixes to rcl clock implementation. (#688)
d721611 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @ahcorde
Improve wait sets test coverage. (#683)
49b6e09 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @ahcorde
Improve rcl timer test coverage. (#680)
30d777e 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@Blast545 @ahcorde
Improve subscription coverage (#681)
063aa31 
* Add bad argument tests for subscription.c
* Add missing rcl_reset_error()
* Add test failing cyclone
* Disable test not working for rmw_cyclone_cpp
* Add simple bad alloc test
* Add tests enclave_name
* Revert "Add tests enclave_name"
* Move init/fini tests
* Add auxiliar testing class
* Reformat into smaller tests
* Add checks ini/fini rmw messages
* Add issue report for disabled test
* Add assert for msg init
* Add bad_allocator test

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@Blast545 @ahcorde
Remove unused check context.c (#691)
96d27ab 
* Remove unused check context.c
* Add test for functionality removed
* Add rcl_reset_error() statement

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
@hidmic @ahcorde
Improve rcl init test coverage. (#684)
261a133 
* Improve rcl init test coverage.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

* Address peer review comments.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@ahcorde ahcorde requested a review from brawner October 8, 2020 10:07
@ahcorde ahcorde self-assigned this Oct 8, 2020
@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 8, 2020

Compiling up-to rcl and testing rcl:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@brawner
Copy link
Contributor

brawner commented Oct 8, 2020

Rebuilding windows. That failure doesn't seem related
Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 16, 2020 •
edited
Loading

Rebuilding Windows

Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 16, 2020

@brawner CI is green!

@ahcorde ahcorde merged commit 6ec0c6c into foxy Oct 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/backport/test branch October 16, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brawner brawner brawner approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahcorde @brawner @hidmic @Blast545