Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Foxy backport] Improve error message for malformed YAML files #823

Closed
wants to merge 1 commit into from
Closed

[Foxy backport] Improve error message for malformed YAML files #823

wants to merge 1 commit into from

Conversation

simutisernestas
Copy link

Backport #556 to Foxy as mentioned in #815.

@simutisernestas
Copy link
Author

i've missed test failing somehow, i'll update it later

@jacobperron jacobperron added the bug Something isn't working label Oct 9, 2020
backport of improved error message for malformed yaml
409f636 
Signed-off-by: Ernestas <ernestas@neurotechnology.com>
@simutisernestas
Copy link
Author

@jacobperron could you please review the PR?

@jacobperron jacobperron self-assigned this Oct 16, 2020
@jacobperron
Copy link
Member

@simutisernestas The __params:= syntax is invalid in Foxy (it was deprecated in Eloquent and subsequently removed in Foxy). Also, with the latest version of rcl in Foxy, we see a reasonable error message (as I commented in #815 (comment)). I don't think this backport is necessary anymore. Can you confirm if this is still an issue in Foxy?

@simutisernestas
Copy link
Author

simutisernestas commented Oct 17, 2020 •
edited
Loading

Yes, you are right. I get a proper error message now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jacobperron jacobperron

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simutisernestas @jacobperron