Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete subscription API test coverage #734

Merged
merged 10 commits into from
Aug 12, 2020
Merged

Complete subscription API test coverage #734

merged 10 commits into from
Aug 12, 2020

Commits on Aug 12, 2020

  1. Complete subscription test coverage. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    89d7d99 View commit details
    Browse the repository at this point in the history

  2. Address peer review comments. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    2546414 View commit details
    Browse the repository at this point in the history

  3. Collapse mocking_utils into one. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    3f3b2fc View commit details
    Browse the repository at this point in the history

  4. Comment on message loaning mocks. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    d9acecf View commit details
    Browse the repository at this point in the history

  5. Alphasort package test dependencies. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    436842b View commit details
    Browse the repository at this point in the history

  6. Comment on dummy comparison operators. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    bafb0e0 View commit details
    Browse the repository at this point in the history

  7. Use constexpr where possible. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    5f3d1ad View commit details
    Browse the repository at this point in the history

  8. Relocate loaned messages API tests. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    c0cf861 View commit details
    Browse the repository at this point in the history

  9. Reformat mocking lambda. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    cf68a37 View commit details
    Browse the repository at this point in the history

  10. Use named variable for improved readability. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    ccf23df View commit details
    Browse the repository at this point in the history