Cmake issues

[jacquelinekay]

Fixes #50

Also cleans up a useless check in CMake pointed out by @dirk-thomas.

[dhood]

doesn't seem to fix #52

[dhood]

what's your gcc version? that's at least one thing I have different to the buildfarm (where everything is fine)

[jacquelinekay]

It's 4.6; I just uninstalled 4.6 and replaced it with 4.8 to see if I can reproduce it.

[dirk-thomas]

The changes look good to me. If CI is passing and shows the separate test results +1.

[jacquelinekay]

I launched CI with --end-with rcl.

http://ci.ros2.org/job/ci_linux/1233/
http://ci.ros2.org/job/ci_osx/990
http://ci.ros2.org/job/ci_windows/1272

[jacquelinekay]

http://ci.ros2.org/job/ci_linux/1233/testReport/projectroot.home.rosbuild.ci_scripts.ws.src.ros2.rcl/rcl/test_service__rmw_opensplice_cpp/
http://ci.ros2.org/job/ci_linux/1233/testReport/projectroot.home.rosbuild.ci_scripts.ws.src.ros2.rcl/rcl/test_services__rmw_connext_cpp/
http://ci.ros2.org/job/ci_linux/1233/testReport/projectroot.home.rosbuild.ci_scripts.ws.src.ros2.rcl/rcl/test_services__rmw_connext_dynamic_cpp/

[jacquelinekay]

it is a bit strange that the second two links that I posted don't have the gtest output that the first one does. But if you look at the console output in the Jenkins job, then it's clear that the test has the correct rmw implementation suffix now.

[dirk-thomas]

The first link is for the gtest test_service with rmw_opensplice_cpp.

The second and third link is for the nosetests test_service**s** with rmw_connext_cpp and rmw_connext_dynamic_cpp.

The second and third test you are interested in are:

• http://ci.ros2.org/job/ci_linux/1233/testReport/projectroot.home.rosbuild.ci_scripts.ws.src.ros2.rcl/rcl/test_service__rmw_connext_cpp/
• http://ci.ros2.org/job/ci_linux/1233/testReport/projectroot.home.rosbuild.ci_scripts.ws.src.ros2.rcl/rcl/test_service__rmw_connext_dynamic_cpp/

[jacquelinekay]

ah, thanks for pointing that out