Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset error message before setting a new one, embed the original one #501

Merged
merged 2 commits into from
Sep 17, 2019

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Sep 16, 2019

Fixes an issue reported in ros-navigation/navigation2#1079 (comment)

Prevents to overwrite the error state.

CI builds testing --packages-above rcl-lifecycle:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels Sep 16, 2019
@dirk-thomas dirk-thomas self-assigned this Sep 16, 2019
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas
Copy link
Member Author

Linter warnings addressed in fb5b56b.

@dirk-thomas dirk-thomas merged commit a9af082 into master Sep 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/lifecycle-error-msgs branch September 17, 2019 15:54
zmichaels11 pushed a commit to zmichaels11/rcl that referenced this pull request Sep 20, 2019
…os2#501)

* reset error message before setting a new one, embed the original one

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* fix max line length

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
mjcarroll pushed a commit that referenced this pull request Sep 20, 2019
…501) (#505)

* reset error message before setting a new one, embed the original one

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* fix max line length

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants