Fix atomics on Windows #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
lgtm |
emersonknapp
pushed a commit
to aws-ros-dev/rcl
that referenced
this pull request
Jun 3, 2019
Factor out python data used in logging_macros empy template
ivanpauno
pushed a commit
that referenced
this pull request
Jan 2, 2020
Add rmw_waitset_t and create/destroy functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the macros for atomic instructions on Windows, the
objectvariable is a pointer to an int, so it will always be 64-bit for 64-bit systems or 32-bit for 32-bit systems. The macros were not defined for 8-bit integer sizes so I added them in here. Also added error-checking for unsupported types.