Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Action graph API #411

Merged
merged 16 commits into from
Apr 14, 2019
Merged

Add Action graph API #411

merged 16 commits into from
Apr 14, 2019

Commits on Apr 10, 2019

  1. Add action graph API 

    Builds on top of the rcl graph API.
A list of action names associated with action clients can be constructed by
looking for subscriber topic names that have the suffix "/_action/feedback".
Likewise, action servers are associated with publisher topic names with the same suffix.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    2fb614e View commit details
    Browse the repository at this point in the history

  2. Enable multiple rmw action graph API tests 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    6207578 View commit details
    Browse the repository at this point in the history

  3. Use ament_target_dependencies for osrf_testing_tools_cpp 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    11f3229 View commit details
    Browse the repository at this point in the history

  4. Fix lint errors 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    fdcfe29 View commit details
    Browse the repository at this point in the history

  5. Refactor 

    * Move graph API common implementation to local function
* Refactor tests

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    ec69e91 View commit details
    Browse the repository at this point in the history

  6. Disable graph tests with OpenSplice 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    1f77808 View commit details
    Browse the repository at this point in the history

  7. Include graph.h in rcl_action.h 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    689a051 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. Remove duplicate test 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    f9c7161 View commit details
    Browse the repository at this point in the history

  2. Prefix increment operators 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    e738aaa View commit details
    Browse the repository at this point in the history

  3. Rename 'suffix' -> 'identifier' 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    91c10ca View commit details
    Browse the repository at this point in the history

  4. Add missing finalize calls and remove redundant branch 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    2923012 View commit details
    Browse the repository at this point in the history

  5. Finalize names and types struct on error 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    57e2280 View commit details
    Browse the repository at this point in the history

  6. Fix bugs in tests 

    Pass valid names and types struct and update expected error code.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    a70eac7 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. Add zero allocator tests 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    3adab6b View commit details
    Browse the repository at this point in the history

  2. Fix indentation 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    9e9c238 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2019

  1. Check if action identifiers are the suffix 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Apr 13, 2019
    Configuration menu
    Copy the full SHA
    661cab0 View commit details
    Browse the repository at this point in the history