Set disable loan to on by default. #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
SteveMacenski
approved these changes
Oct 12, 2023
fujitatomoya
approved these changes
Oct 12, 2023
wjwwood
approved these changes
Oct 17, 2023
|
CI:
|
It is currently not safe to use; see the executor code in rclcpp for more information. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
force-pushed
the
clalancette/disable-executor-loan
branch
from
72a72bc
to
4b08cca
Compare
|
Another CI try now that this has been rebased:
|
delete-merged-branch
bot
deleted the
clalancette/disable-executor-loan
branch
This was referenced Nov 3, 2023
|
@Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
It is currently not safe to use; see the executor code in rclcpp for more information. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 1b01127) # Conflicts: # rcl/include/rcl/subscription.h # rcl/src/rcl/subscription.c # rcl/test/rcl/test_subscription.cpp
mergify bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
It is currently not safe to use; see the executor code in rclcpp for more information. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 1b01127)
clalancette
added a commit
that referenced
this pull request
Nov 9, 2023
clalancette
pushed a commit
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently not safe to use; see the executor code in rclcpp for more information.