Skip to content

Commit

Permalink
Make sure to initialize the bool field. (#426)
Browse files Browse the repository at this point in the history
This way we avoid tripping a Fast-CDR check for a 0 or 1
in the bool field.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
  • Loading branch information
clalancette authored Apr 30, 2019
1 parent f943e6d commit f98d37e
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions rcl/test/rcl/test_service.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,12 @@ TEST_F(CLASSNAME(TestServiceFixture, RMW_IMPLEMENTATION), test_service_nominal)
// Initialize a request.
test_msgs__srv__Primitives_Request client_request;
test_msgs__srv__Primitives_Request__init(&client_request);
// TODO(clalancette): the C __init methods do not initialize all structure
// members, so the numbers in the fields not explicitly set is arbitrary.
// The CDR deserialization in Fast-CDR requires a 0 or 1 for bool fields,
// so we explicitly initialize that even though we don't use it. This can be
// removed once the C __init methods initialize all members by default.
client_request.bool_value = false;
client_request.uint8_value = 1;
client_request.uint32_value = 2;
int64_t sequence_number;
Expand Down

0 comments on commit f98d37e

Please sign in to comment.