Guard against null namespaces

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ros2 · Mar 12, 2020 · a4b89a1 · a4b89a1
1 parent 922f2e8
commit a4b89a1
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/rcl/src/rcl/graph.c b/rcl/src/rcl/graph.c
@@ -352,6 +352,13 @@ rcl_get_node_names(
       return RCL_RET_ERROR;
     }
   }
+  // Check that none of the node namespaces are NULL
+  for (size_t i = 0u; i < node_names->size; ++i) {
+    if (!node_namespaces->data[i]) {
+      RCL_SET_ERROR_MSG("NULL node namespace returned by the RMW layer");
+      return RCL_RET_ERROR;
+    }
+  }
   return RCL_RET_OK;
 }