Revert "Revert "Changes the default 3rd party logger from rcl_logging…

…_noop to… (#436)" This reverts commit 667443b.
ros2 · May 17, 2019 · 4b6065c · 4b6065c
1 parent 2380a1a
commit 4b6065c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/rcl/cmake/get_default_rcl_logging_implementation.cmake b/rcl/cmake/get_default_rcl_logging_implementation.cmake
@@ -24,13 +24,13 @@
 macro(get_default_rcl_logging_implementation var)
 
   # if logging implementation already specified or RCL_LOGGING_IMPLEMENTATION environment variable
-  # is set then use that, otherwise default to using rcl_logging_noop
+  # is set then use that, otherwise default to using rcl_logging_log4cxx
   if(NOT "${RCL_LOGGING_IMPLEMENTATION}" STREQUAL "")
     set(_logging_implementation "${RCL_LOGGING_IMPLEMENTATION}")
   elseif(NOT "$ENV{RCL_LOGGING_IMPLEMENTATION}" STREQUAL "")
     set(_logging_implementation "$ENV{RCL_LOGGING_IMPLEMENTATION}")
   else()
-    set(_logging_implementation rcl_logging_noop)
+    set(_logging_implementation rcl_logging_log4cxx)
   endif()
 
   # persist implementation decision in cache

diff --git a/rcl/package.xml b/rcl/package.xml
@@ -28,7 +28,7 @@
   <exec_depend>rcutils</exec_depend>
   <exec_depend>rosidl_default_runtime</exec_depend>
 
-  <depend>rcl_logging_noop</depend> <!-- the default logging impl -->
+  <depend>rcl_logging_log4cxx</depend> <!-- the default logging impl -->
   <depend>rmw_implementation</depend>
 
   <test_depend>ament_cmake_gtest</test_depend>