Implement suggestions of issue #308 #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloretz
previously requested changes
Apr 25, 2022
There was a problem hiding this comment.
Thanks for the PR @Keng12!
Would you be willing to signoff the commits on this PR to satisfy the DCO bot?
With your branch checked out, this command will signoff the existing commit.
git rebase HEAD~1 --signoff
For additional commits, the sign off line can be added -s option when committing.
git commit -s
|
Thanks for the hint! I signed off my commit this time. I messed up the signing and now some commits on my branch say that I signed off some previous commits unrelated to me. Can you tell me how to fix it? |
Keng12
force-pushed
the
master
branch
2 times, most recently
from
2fef256
to
4ea2668
Compare
Signed-off-by: Keng12 <k.chaig1@gmail.com>
|
I fixed the signing and commit history. |
jacobperron
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #308 as suggested by @sloretz